Skip to content

[APMLP-849] Refactor remaining ImageResolver files into imageresolver package#45151

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomainfrom
erikayasuda/imageresolver_pkg
Jan 20, 2026
Merged

[APMLP-849] Refactor remaining ImageResolver files into imageresolver package#45151
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomainfrom
erikayasuda/imageresolver_pkg

Conversation

@erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Jan 15, 2026 •
edited
Loading

What does this PR do?

Continuing the refactor of the ImageResolver code into the imageresolver package for clear delineation of the code. See first part here. Namely, the changes are:

  • Moving image_resolver.go and image_resolver_test.go into imageresolver/
  • Renaming functions and types to avoid stutter like imageresolver.NewImageResolver(...)
  • Creating an image.go file to separate definitions representing images handled by the Resolvers
  • Updating references outside of the imageresolver package to reflect the above changes

No functional changes are introduced by this PR, only refactor/clean up.

Motivation

The original imageresolver code was hard to read, and the goal here is to make this easier to read and maintain for all repo contributors. This is also to help make future changes easier to implement along with the general refactor initiative for the autoinstrumentation cluster agent code.

Describe how you validated your changes

Verified existing tests all pass.

Additional Notes

@github-actions github-actions bot added team/container-platform The Container Platform Team team/injection-platform medium review PR review might take time labels Jan 15, 2026
@erikayasuda erikayasuda changed the title Refactor remaining ImageResolver files into imageresolver package Refactor remaining ImageResolver files into imageresolver package Jan 15, 2026
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jan 15, 2026 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 940002c5-eedc-46b6-a4ac-b1e39e08c6d0

Baseline: 4dc4920
Comparison: 2d903cd
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +0.68 [-2.30, +3.66] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +1.63 [+0.14, +3.12] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput +0.92 [+0.83, +1.01] 1 Logs
➖ docker_containers_memory memory utilization +0.76 [+0.69, +0.83] 1 Logs
➖ docker_containers_cpu % cpu utilization +0.68 [-2.30, +3.66] 1 Logs
➖ ddot_metrics_sum_delta memory utilization +0.23 [+0.04, +0.42] 1 Logs
➖ ddot_logs memory utilization +0.22 [+0.16, +0.29] 1 Logs
➖ file_tree memory utilization +0.21 [+0.16, +0.26] 1 Logs
➖ quality_gate_idle memory utilization +0.08 [+0.03, +0.12] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.02 [-0.01, +0.06] 1 Logs bounds checks dashboard
➖ tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.08, +0.10] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.40, +0.42] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.13, +0.14] 1 Logs
➖ otlp_ingest_logs memory utilization +0.00 [-0.10, +0.11] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.05, +0.04] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.12] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.05 [-0.43, +0.33] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.06 [-0.55, +0.43] 1 Logs
➖ ddot_metrics memory utilization -0.07 [-0.28, +0.14] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.22 [-0.43, -0.01] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_cumulative memory utilization -0.29 [-0.45, -0.13] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.29 [-0.52, -0.06] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.32 [-0.37, -0.26] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.39 [-0.53, -0.24] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (target internal profiling)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 11 (x4) Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 11 (x3) Oom killed Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

erikayasuda
erikayasuda commented Jan 16, 2026
View reviewed changes
pkg/clusteragent/admission/mutate/autoinstrumentation/imageresolver/image_resolver.go
@@ -148,20 +145,9 @@ func (r *remoteConfigImageResolver) Resolve(registry string, repository string,
return resolvedImage, true
}

func isDatadoghqRegistry(registry string, datadoghqRegistries map[string]struct{}) bool {
Copy link
Contributor Author

@erikayasuda erikayasuda Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to util.go

@erikayasuda erikayasuda changed the title Refactor remaining ImageResolver files into imageresolver package [APMLP-849] Refactor remaining ImageResolver files into imageresolver package Jan 16, 2026
@erikayasuda erikayasuda added the changelog/no-changelog No changelog entry needed label Jan 16, 2026
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 16, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 4dc4920
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 705.568 MiB
✅ agent_deb_amd64_fips 700.857 MiB
✅ agent_heroku_amd64 327.047 MiB
✅ agent_msi 571.846 MiB
✅ agent_rpm_amd64 705.554 MiB
✅ agent_rpm_amd64_fips 700.844 MiB
✅ agent_rpm_arm64 687.073 MiB
✅ agent_rpm_arm64_fips 683.206 MiB
✅ agent_suse_amd64 705.554 MiB
✅ agent_suse_amd64_fips 700.844 MiB
✅ agent_suse_arm64 687.073 MiB
✅ agent_suse_arm64_fips 683.206 MiB
✅ docker_agent_amd64 767.711 MiB
✅ docker_agent_arm64 773.843 MiB
✅ docker_agent_jmx_amd64 958.589 MiB
✅ docker_agent_jmx_arm64 953.441 MiB
✅ docker_cluster_agent_amd64 180.745 MiB
✅ docker_cluster_agent_arm64 196.602 MiB
✅ docker_cws_instrumentation_amd64 7.135 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 38.843 MiB
✅ docker_dogstatsd_arm64 37.128 MiB
✅ dogstatsd_deb_amd64 30.067 MiB
✅ dogstatsd_deb_arm64 28.212 MiB
✅ dogstatsd_rpm_amd64 30.067 MiB
✅ dogstatsd_suse_amd64 30.067 MiB
✅ iot_agent_deb_amd64 43.120 MiB
✅ iot_agent_deb_arm64 40.229 MiB
✅ iot_agent_deb_armhf 40.814 MiB
✅ iot_agent_rpm_amd64 43.120 MiB
✅ iot_agent_suse_amd64 43.120 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 +37.57 KiB (0.02% increase) 173.286 → 173.323 → 174.490
✅ agent_deb_amd64_fips -7.73 KiB (0.00% reduction) 172.241 → 172.234 → 173.750
✅ agent_heroku_amd64 +3.97 KiB (0.00% increase) 87.137 → 87.141 → 88.450
✅ agent_msi neutral 142.980 MiB
✅ agent_rpm_amd64 -19.34 KiB (0.01% reduction) 175.957 → 175.938 → 177.660
✅ agent_rpm_amd64_fips +41.46 KiB (0.02% increase) 175.056 → 175.096 → 176.600
✅ agent_rpm_arm64 +11.46 KiB (0.01% increase) 159.421 → 159.432 → 161.260
✅ agent_rpm_arm64_fips +7.23 KiB (0.00% increase) 158.740 → 158.747 → 160.550
✅ agent_suse_amd64 -19.34 KiB (0.01% reduction) 175.957 → 175.938 → 177.660
✅ agent_suse_amd64_fips +41.46 KiB (0.02% increase) 175.056 → 175.096 → 176.600
✅ agent_suse_arm64 +11.46 KiB (0.01% increase) 159.421 → 159.432 → 161.260
✅ agent_suse_arm64_fips +7.23 KiB (0.00% increase) 158.740 → 158.747 → 160.550
✅ docker_agent_amd64 +3.49 KiB (0.00% increase) 261.147 → 261.150 → 262.450
✅ docker_agent_arm64 +2.72 KiB (0.00% increase) 250.127 → 250.130 → 252.630
✅ docker_agent_jmx_amd64 neutral 329.786 MiB
✅ docker_agent_jmx_arm64 neutral 314.750 MiB
✅ docker_cluster_agent_amd64 +3.86 KiB (0.01% increase) 63.856 → 63.860 → 64.490
✅ docker_cluster_agent_arm64 -4.59 KiB (0.01% reduction) 60.143 → 60.139 → 61.170
✅ docker_cws_instrumentation_amd64 neutral 2.994 MiB
✅ docker_cws_instrumentation_arm64 neutral 2.726 MiB
✅ docker_dogstatsd_amd64 neutral 15.038 MiB
✅ docker_dogstatsd_arm64 neutral 14.357 MiB
✅ dogstatsd_deb_amd64 neutral 7.952 MiB
✅ dogstatsd_deb_arm64 neutral 6.827 MiB
✅ dogstatsd_rpm_amd64 neutral 7.962 MiB
✅ dogstatsd_suse_amd64 neutral 7.962 MiB
✅ iot_agent_deb_amd64 neutral 11.300 MiB
✅ iot_agent_deb_arm64 neutral 9.657 MiB
✅ iot_agent_deb_armhf neutral 9.854 MiB
✅ iot_agent_rpm_amd64 neutral 11.314 MiB
✅ iot_agent_suse_amd64 neutral 11.314 MiB

@erikayasuda erikayasuda added qa/done QA done before merge and regressions are covered by tests and removed qa/skip-qa labels Jan 16, 2026
@erikayasuda erikayasuda marked this pull request as ready for review January 16, 2026 19:45
@erikayasuda erikayasuda requested review from a team as code owners January 16, 2026 19:45
@erikayasuda
Copy link
Contributor Author

erikayasuda commented Jan 20, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 20, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-20 20:04:28 UTC ℹ️ Start processing command /merge

2026-01-20 20:04:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 58m (p90).

2026-01-20 21:01:03 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 818a050 into main Jan 20, 2026
350 of 352 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the erikayasuda/imageresolver_pkg branch January 20, 2026 21:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2026
@github-actions github-actions bot added this to the 7.76.0 milestone Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iamluc iamluc iamluc approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team team/injection-platform

Projects

None yet

Milestone

7.76.0

Development

Successfully merging this pull request may close these issues.

2 participants

@erikayasuda @iamluc